en, zh: update documentation about PodRestarter #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <[email protected]>
ran-huang
changed the title
ran-huang
added
needs-cherry-pick-release-1.1
| @@ -85,13 +85,3 @@ To activate the graceful logoff feature, you need to enable some related configu | |||
| 2. Install or update TiDB Operator. | |||
|
|
|||
| To install or update TiDB Operator, see [Deploy TiDB Operator in Kubernetes](deploy-tidb-operator.md). | |||
|
|
|||
There was a problem hiding this comment.
Please remove the whole section of https://docs.pingcap.com/tidb-in-kubernetes/dev/restart-a-tidb-cluster#gracefully-restart-a-single-pod-of-the-tidb-component
en/restart-a-tidb-cluster.md
Outdated
| @@ -36,23 +36,23 @@ If you find that the memory leak occurs in a Pod during use, you need to restart | |||
| storage: "1Gi" | |||
| config: {} | |||
| annotations: | |||
| tidb.pingcap.com/restartedAt: "202004201200" | |||
| tidb.pingcap.com/restartedAt: 2020-04-20 12:00 | |||
There was a problem hiding this comment.
Suggested change
| tidb.pingcap.com/restartedAt: 2020-04-20 12:00 | |
| tidb.pingcap.com/restartedAt: 2020-04-20-12-00 |
There was a problem hiding this comment.
在 571115b 中改成了 rfc3339 的格式。
zh/restart-a-tidb-cluster.md
Outdated
| @@ -32,23 +32,23 @@ aliases: ['/docs-cn/tidb-in-kubernetes/dev/restart-a-tidb-cluster/'] | |||
| storage: "1Gi" | |||
| config: {} | |||
| annotations: | |||
| tidb.pingcap.com/restartedAt: "202004201200" | |||
| tidb.pingcap.com/restartedAt: 2020-04-20 12:00 | |||
There was a problem hiding this comment.
comments 同上，还有下面的重启单个 Pod 部分全部删掉。
|
@lonng, please update your pull request. |
2 similar comments
|
@lonng, please update your pull request. |
|
@lonng, please update your pull request. |
|
No updates for a long time, close PR. |
|
@lonng Please address comments. Thanks~ |
Signed-off-by: Lonng <[email protected]>
ti-srebot
approved these changes
Oct 19, 2020
ti-srebot
pushed a commit
to ti-srebot/docs-tidb-operator
that referenced
this pull request
Oct 19, 2020
Signed-off-by: ti-srebot <[email protected]>
7 tasks
|
cherry pick to release-1.1 in PR #779 |
ran-huang
pushed a commit
that referenced
this pull request
Oct 19, 2020
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Lonng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng [email protected]
What is changed, added or deleted? (Required)
Update documentation about PodRestarter.
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/tidb-operator#3296
Do your changes match any of the following descriptions?