Remove the PodRestarter controller and tidb.pingcap.com/pod-defer-deleting annotation
#3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3296 +/- ##
==========================================
+ Coverage 39.76% 42.33% +2.57%
==========================================
Files 172 159 -13
Lines 17558 16371 -1187
==========================================
- Hits 6982 6931 -51
+ Misses 9925 8802 -1123
+ Partials 651 638 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonng
requested review from
lichunzhu and
DanielZhangQD
and removed request for
DanielZhangQD
ti-srebot
approved these changes
Sep 22, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Sep 22, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-1.0 in PR #3300 |
7 tasks
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Sep 22, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-1.1 in PR #3301 |
lonng
added a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Sep 22, 2020
…leting` annotation (pingcap#3296) Signed-off-by: Lonng <[email protected]>
Yisaer
pushed a commit
that referenced
this pull request
Sep 23, 2020
…leting` annotation (#3296) (#3301) Signed-off-by: Lonng <[email protected]> Co-authored-by: Lonng <[email protected]>
cvvz
pushed a commit
to cvvz/tidb-operator
that referenced
this pull request
Oct 18, 2020
…leting` annotation (pingcap#3296) Signed-off-by: Lonng <[email protected]>
7 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This
PodRestarteris used to restart a pod by annotating it withtidb.pingcap.com/pod-defer-deleting. However, there is no user to use this feature because we recommandate users to restart pods gracefully via instrucations https://docs.pingcap.com/tidb-in-kubernetes/dev/restart-a-tidb-cluster#performing-a-graceful-rolling-restart-to-all-pods-in-a-component. ThePodRestartercontrol will retrieve all pods belongs to the current TiDBCluster instance when everysynciteration and delete some of it, I think there is unnecessary cost.What is changed and how does it work?
Remove the
PodRestarterCheck List
Tests
Code changes
Does this PR introduce a user-facing change?: