Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the data dir of monitored instance #10684

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix the data dir of monitored instance #10684

merged 1 commit into from
Oct 9, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Oct 9, 2022 •
edited
Loading

What is changed, added or deleted? (Required)

Fix the data dir of monitored instance from "/tidb-data-monitored-9100" to "/tidb-data/monitored-9100"

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. translation/doing This PR's assignee is translating this PR. ONCALL Relates to documentation oncall. labels Oct 9, 2022
@Oreoxmt Oreoxmt self-assigned this Oct 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2022
@Oreoxmt Oreoxmt mentioned this pull request Oct 9, 2022
Merged
13 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. and removed translation/doing This PR's assignee is translating this PR. labels Oct 9, 2022
superlzs0476
superlzs0476 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

superlzs0476
superlzs0476 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 9, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
shichun-0415
shichun-0415 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3fc811f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2022
This was referenced Oct 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10687.

This was referenced Oct 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10688.

This was referenced Oct 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10689.

This was referenced Oct 9, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10690.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10691.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10692.

This was referenced Oct 9, 2022
Merged
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10693.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10686)
78a8c05
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10685)
0f2c372
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10689)
2a7e38f
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10687)
b77e415
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10688)
468b784
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10690)
ef71a2a
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10692)
4c14794
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10691)
0493da1
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
Fix the data dir of monitored instance (#10684) (#10693)
b0add01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@superlzs0476 superlzs0476 superlzs0476 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oreoxmt @ti-chi-bot @superlzs0476 @shichun-0415