Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keywords (#15443) #15593

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #15443

What is changed, added or deleted? (Required)

  1. The scripts/check-keywords.sh script didn't check they "TiDBKeyword" section of "parser.y"
  2. The entries in the docs from the "TiDBKeyword" section were labeled as reserved, while that doesn't seem to be the case.
  3. Various missing keywords.

This shows the behavior for TIDB and DESC which are both listed as reserved keyword in the docs:

sql> CREATE TABLE TIDB(id INT);
Query OK, 0 rows affected (0.2196 sec)

sql> CREATE TABLE DESC(id INT);
ERROR: 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 17 near "DESC(id INT)" 

I would expect both to fail, but it looks like TIDB (from the "TiDBKeyword" list) isn't actually reserved.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 5, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2023
16 tasks
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 5, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 49d2067 into pingcap:release-7.5 Dec 5, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants