Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status-variables: Add conditional status that are not available with unistore #15918

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 29, 2023

What is changed, added or deleted? (Required)

When running TiDB with tiup playground, tiup cluster, tidb-operator or other situations where it runs with at least PD, TiKV and TiDB there are more status variables available than when running with only TiDB (./bin/tidb-server, unistore). This adds the missing variables.

See also pingcap/tidb#22286

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Dec 29, 2023

  1. We could add something like "not available with unistore" or "only available with TiKV", but I don't think we should.
  2. These GC status vars don't seem to be mentioned in the GC docs. We could consider to add a link from the GC docs back to the status var docs.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2024
@ran-huang ran-huang self-assigned this Jan 24, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
Copy link

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 08:47:55.510396225 +0000 UTC m=+864117.074693925: ☑️ agreed by ran-huang.
  • 2024-02-29 10:38:43.097185481 +0000 UTC m=+1131211.844808591: ☑️ agreed by qiancai.

Copy link

ti-chi-bot bot commented Feb 29, 2024

@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai assigned qiancai and unassigned ran-huang Feb 29, 2024
@qiancai
Copy link
Collaborator

qiancai commented Feb 29, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 29, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 29, 2024
@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 labels Feb 29, 2024
@qiancai
Copy link
Collaborator

qiancai commented Feb 29, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit a8648ba into pingcap:master Feb 29, 2024
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16650.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16651.

ti-chi-bot bot pushed a commit that referenced this pull request Feb 29, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 29, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 7, 2024
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants