-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: Add status variables for tikv statistics #22286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
m[tidbGCLeaderUUID] = v | ||
} | ||
if v, err := w.loadValueFromSysTable(gcLeaderDescKey); err == nil { | ||
m[tidbGCLeaderDesc] = v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The leader desc usually contains the leader node's hostname or IP address. Since mysql.tidb will be hidden for security concern, can this be exposed directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to add filtering of SHOW [GLOBAL] STATUS
to security enhanced mode. The proposal is closed for now because it was moved out of this sprint. cc @SunRunAway
Moving to SHOW STATUS
is still beneficial though, since filtering from here has a cleaner semantic than patching out results from SELECT * FROM mysql.tidb
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@MyonKeminta: Please use If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 42e101c
|
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
What problem does this PR solve?
Problem Summary:
In the DBaaS, the table
mysql.tidb
will be hidden (enforced by Security Enhanced mode, WIP).This follows on from #21988 and mirrors the tikv statistics in
SHOW GLOBAL STATUS
. For non-DBaaS installs, the reading frommysql.tidb
will continue to be supported (although for consistency between the two, documentation will be updated to point toSHOW GLOBAL STATUS
).What is changed and how it works?
How it Works:
TiDB does not make much use of
STATUS
variables, but it is the standard way for MySQL to expose various statistics. Here is an example with this added:Related changes
Check List
Tests
Side effects
Release note
SHOW GLOBAL STATUS
.