-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update garbage collection docs (#4552) #5055
Update garbage collection docs (#4552) #5055
Conversation
Signed-off-by: ti-srebot <[email protected]>
@morgo you're already a collaborator in bot's repo. |
Do we need to merge this PR after 5.0 GA is released? @morgo |
I don't quite understand how the docs branching is being done for 5.0. I thought since tidb created It looks like PRs are being held (for example: #5007 ), but I think it's fine to merge and say a change is effective since 5.0 even when 5.0 is not yet released? I have noticed we do this with point releases too (not merge docs related to a 4.0.11 feature until 4.0.11 is released). It increases merge conflicts/management pains to keep the PRs open. |
I'd like to transfer this conversation to Slack if you don't mind. I've shared the docs branching plan with you there. We can continue our discussion there.
|
Please get me involved, what is the proper time to merge it? |
Now is the time to merge. We have aborted the auto-deployment for the release-5.0 branch. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1837c72
|
cherry-pick #4552 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In docs repo: git pr https://github.com/pingcap/docs/pull/5055
After apply modifications, you can push your change to this PR via:
First-time contributors' checklist
What is changed, added or deleted? (Required)
This updates the docs for pingcap/tidb#21988 (now merged).
21988 still allows the previous methods for updating, but because these changes are not validated, they should not be recommended. Incorrect configuration can lead to strange behaviors.
Partially address #4549 (for backup page mentioned, there are still other pages that need readability improvements)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?