We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
func (n *SelectStmt) Restore(ctx *RestoreCtx) error { ...... if n.TableHints != nil && len(n.TableHints) != 0 { ctx.WritePlain("/*+ ") for i, tableHint := range n.TableHints { if err := tableHint.Restore(ctx); err != nil { errors.Annotatef(err, "An error occurred while restore SelectStmt.TableHints[%d]", i) } } ctx.WritePlain("*/ ") } ...... }
Why not return errors.Annotatef()? If error occurs, the error will disappear and cannot be found in return value.
return errors.Annotatef()
The text was updated successfully, but these errors were encountered:
This looks like a typo. Would you mind filing a PR fixing this? Thanks!
Sorry, something went wrong.
ast: fix return err value in Restore (#224) (#226)
c3e1b30
ast: fix return err value in Restore (pingcap#224) (pingcap#226)
82e38e8
2032adc
No branches or pull requests
Question
Why not
return errors.Annotatef()
? If error occurs, the error will disappear and cannot be found in return value.The text was updated successfully, but these errors were encountered: