Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: fix return err value in Restore (#224) #226

Merged
merged 4 commits into from
Mar 20, 2019
Merged

ast: fix return err value in Restore (#224) #226

merged 4 commits into from
Mar 20, 2019

Conversation

loxp
Copy link
Contributor

@loxp loxp commented Feb 27, 2019

What problem does this PR solve?

Fix #224, add return keyword when error occurs.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

kennytm
kennytm reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loxp
Copy link
Contributor Author

loxp commented Mar 2, 2019

@kennytm How to get one more approving review?

@shenli
Copy link
Member

shenli commented Mar 2, 2019

@loxp I will call someone to review this PR. Thanks!

alivxxx
alivxxx approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Mar 4, 2019
@ngaut ngaut merged commit c3e1b30 into pingcap:master Mar 20, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@ngaut
ast: fix return err value in Restore (pingcap#224) (pingcap#226)
82e38e8
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@ngaut
ast: fix return err value in Restore (pingcap#224) (pingcap#226)
2032adc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loxp @shenli @kennytm @alivxxx @ngaut