Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support multiple table rename #1021

Merged
merged 3 commits into from
Oct 28, 2020
Merged

ddl: support multiple table rename #1021

merged 3 commits into from
Oct 28, 2020

Conversation

TszKitLo40
Copy link
Contributor

What problem does this PR solve?

Support multiple table rename in the rename table statement
This is for the issue pingcap/tidb/#9384

What is changed and how it works?

Use TableToTable to replace OldTable and NewTable

Check List

Tests

  • Unit test

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tangenta
tangenta reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 14, 2020
@tangenta tangenta added the DNM label Sep 14, 2020
djshow832
djshow832 reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Sep 17, 2020
ti-srebot
ti-srebot previously approved these changes Sep 17, 2020
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Sep 17, 2020
@TszKitLo40
Copy link
Contributor Author

@tangenta @djshow832 I think we need to add ActionRenameTables to support multiple table renames, PTAL

@TszKitLo40 TszKitLo40 mentioned this pull request Sep 23, 2020
Merged
@lance6716
Copy link
Contributor

PTAL @tangenta, this change will make some of tools have a better table-route (rename upstream table when sync to downstream) code.

AilinKid
AilinKid approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 LGT3. This PR looks very good to our bot. and removed status/LGT2 LGT2 labels Oct 27, 2020
@kennytm
Copy link
Contributor

kennytm commented Oct 27, 2020

@tangenta PTAL, and remove the DNM label if it is ready to merge.

@djshow832 djshow832 merged commit 1328d87 into pingcap:master Oct 28, 2020
This was referenced Oct 28, 2020
Closed
Closed
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@TszKitLo40
ddl: support multiple table rename (pingcap#1021)
da7c6ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@tangenta tangenta tangenta left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
contribution status/LGT3 LGT3. This PR looks very good to our bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TszKitLo40 @CLAassistant @lance6716 @kennytm @AilinKid @tangenta @djshow832 @ti-srebot