using standard error code to replace terror (#982) #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonng
reviewed
Sep 19, 2020
terror/terror.go
Outdated
| if ec, has := rfcCode2errClass[string(rfcCode)[:index]]; has { | ||
| class = ec | ||
| } else { | ||
| log.Warn("Unknown error class", zap.String("class", string(rfcCode)[:index])) |
lonng
reviewed
Sep 19, 2020
terror/terror.go
Outdated
| func (ec ErrClass) New(code ErrCode, message string) *Error { | ||
| rfcCode := ec.initError(code) | ||
| err := errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(rfcCode)) | ||
| errCodeMap[code] = err |
There was a problem hiding this comment.
Is there any concurrent problem?
There was a problem hiding this comment.
yes, this method is not groutine-safe, but always used for global init.
lonng
reviewed
Sep 19, 2020
terror/terror.go
Outdated
| func (ec ErrClass) NewStdErr(code ErrCode, message string, desc string, workaround string) *Error { | ||
| rfcCode := ec.initError(code) | ||
| err := errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(rfcCode), errors.Description(desc), errors.Workaround(workaround)) | ||
| errCodeMap[code] = err |
lonng
reviewed
Sep 19, 2020
| // NotEqual checks if err is not equal to e. | ||
| func (e *Error) NotEqual(err error) bool { | ||
| return !e.Equal(err) | ||
| return errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(fmt.Sprintf("%s:%d", errClass2Desc[ec], code))) |
There was a problem hiding this comment.
What if errClass2Desc[ec] is empty?
There was a problem hiding this comment.
errClass2Desc[ec] will not be empty, because the caller has been init at error class register.
added 2 commits
September 21, 2020 10:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #982 to release-4.0
According to RFC, TiDB need to adjust error format and using standard error to replace terror. The standard error has been implemented in https://github.com/pingcap/errors/tree/standard-error
What is changed and how it works?
Since standard error is very similar with
terror. We can change very few api to replace theterror. Just renameterror.Errorwitherrors.ErrorCheck List
Tests
Code changes
Side effects
Related changes