go mod: upgrade pingcap/tidb and pingcap/errors to latest release-4.0 #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
amyangfei
added
the
release-blocker
|
/lgtm |
amyangfei
force-pushed
the
update-go-mod
branch
from
68f21ed
to
60f1793
Compare
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
lgtm |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
===========================================
Coverage 32.1272% 32.1272%
===========================================
Files 100 100
Lines 11000 11000
===========================================
Hits 3534 3534
Misses 7064 7064
Partials 402 402 |
amyangfei
force-pushed
the
update-go-mod
branch
from
8a99f35
to
623d242
Compare
amyangfei
commented
Sep 21, 2020
| @@ -50,3 +50,5 @@ require ( | |||
| gopkg.in/mgo.v2 v2.0.0-20190816093944-a6b53ec6cb22 // indirect | |||
| upper.io/db.v3 v3.7.1+incompatible | |||
| ) | |||
|
|
|||
| replace github.com/pingcap/tidb-tools => github.com/pingcap/tidb-tools v4.0.0-beta.0.20200921090810-52b9534ff3d5+incompatible | |||
There was a problem hiding this comment.
if we don't use go mod replace here, the tidb-tools always get the following hash
github.com/pingcap/tidb-tools v4.0.6-0.20200828085514-03575b185007+incompatible
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pingcap/errorshas a compatibility fix in pingcap/errors#26, CDC can upgrade to latest tidb release-4.0, in order to pass test with tidb masterWait cherry-pick in tidb release-4.0 and parser release-4.0
What is changed and how it works?
upadte go mod
Check List
Tests
Release note