Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: admin show ddl jobs output confusing with multiple jobs #1210

Merged
merged 5 commits into from
Apr 26, 2021
Merged

ddl: admin show ddl jobs output confusing with multiple jobs #1210

merged 5 commits into from
Apr 26, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Apr 20, 2021 •
edited by kennytm
Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported variable/fields change

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Howie59 Howie59 mentioned this pull request Apr 23, 2021
Open
@Howie59 Howie59 marked this pull request as ready for review April 25, 2021 03:26
@kennytm
Copy link
Contributor

kennytm commented Apr 25, 2021

(prerequisite of pingcap/tidb#24151)

@kennytm
Copy link
Contributor

kennytm commented Apr 25, 2021

/lgtm

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Apr 25, 2021
xiongjiwei
xiongjiwei approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@xiongjiwei xiongjiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Apr 26, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Apr 26, 2021
@kennytm kennytm merged commit 4a1fff1 into pingcap:master Apr 26, 2021
@Howie59 Howie59 deleted the issue-23494 branch April 26, 2021 04:44
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@Howie59 @tiancaiamao
ddl: admin show ddl jobs output confusing with multiple jobs (pingcap…
25c32cf 
…#1210)

* change "none" 2 "queueing"

Signed-off-by: lihaowei <[email protected]>

* 4 review

Signed-off-by: lihaowei <[email protected]>

* restore origin word

* *: change none 2 queueing
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@Howie59 @tiancaiamao
ddl: admin show ddl jobs output confusing with multiple jobs (pingcap…
8c15881 
…#1210)

* change "none" 2 "queueing"

Signed-off-by: lihaowei <[email protected]>

* 4 review

Signed-off-by: lihaowei <[email protected]>

* restore origin word

* *: change none 2 queueing
@zimulala zimulala mentioned this pull request May 7, 2021
Closed
@tangenta tangenta mentioned this pull request Apr 11, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Howie59 @CLAassistant @kennytm @xiongjiwei @ti-srebot