ddl: fix inappropriate schema state output by admin show ddl jobs

[tangenta]

What problem does this PR solve?

Issue Number: close #24420, related to #23494

Problem Summary:

The information "queueing" is introduced by pingcap/parser#1210.

state-none has two meanings:

• one for adding-type DDL, the job hasn't started yet / the job has been rollbacked.
• one for removed-type DDL, the job hasn't started yet / the job has done.

What is changed and how it works?

This PR picks up the work from #31544.

Before this PR:

+--------+---------+------------+---------------+----------------------+-----------+----------+-----------+---------------------+---------------------+---------------------+---------+
| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE      | SCHEMA_STATE         | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME         | START_TIME          | END_TIME            | STATE   |
+--------+---------+------------+---------------+----------------------+-----------+----------+-----------+---------------------+---------------------+---------------------+---------+
|    166 | sbtest  | sbtest1    | add index     | write reorganization |       160 |      162 |         0 | 2022-04-11 14:47:10 | 2022-04-11 14:47:10 | NULL                | running |
|    167 | sbtest2 | sbtest1    | add index     | queueing             |       158 |      164 |         0 | 2022-04-11 14:47:10 | NULL                | NULL                | none    |

After this PR:

mysql> admin show ddl jobs;
+--------+---------+------------+---------------+----------------------+-----------+----------+-----------+---------------------+---------------------+---------------------+----------+
| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE      | SCHEMA_STATE         | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME         | START_TIME          | END_TIME            | STATE    |
+--------+---------+------------+---------------+----------------------+-----------+----------+-----------+---------------------+---------------------+---------------------+----------+
|    154 | sbtest  | sbtest1    | add index     | write reorganization |       146 |      150 |    230400 | 2022-04-11 14:24:59 | 2022-04-11 14:24:59 | NULL                | running  |
|    155 | sbtest2 | sbtest1    | add index     | none                 |       148 |      152 |         0 | 2022-04-11 14:25:00 | NULL                | NULL                | queueing |

Basically, there are 2 changes:

• There is no "queueing" SCHEMA_STATE anymore. Even if the job is in the queue, the SCHEMA_STATE is "none".
• The state "queueing" has been added to the STATE column. It is used to distinguish whether a job is waiting in the DDL queue.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

See the result above.

• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that the schema state output by 'admin show ddl jobs' is inappropriate.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• wjhuang2016
• zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f059d566ea68ab19f60519993ce42acf09eb9eb9

[wjhuang2016]

What's the manual test and its result?

[tangenta]

@wjhuang2016 I have updated the manual test result. The difference is shown in the last column.

[zimulala]

LGTM

[zimulala]

Please add Release note for this PR.

[easonn7]

LGTM

[tangenta]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f059d56

[ti-chi-bot]

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.