parser, ast: add SET ROLE support
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Mar 1, 2019
tiancaiamao
reviewed
Mar 4, 2019
|
LGTM |
|
tidb pr: pingcap/tidb#9581 |
kennytm
reviewed
Mar 18, 2019
ast/misc.go
Outdated
| case SetRoleAllExcept: | ||
| ctx.WriteKeyWord(" ALL EXCEPT") | ||
| } | ||
| if len(n.RoleList) > 0 { |
There was a problem hiding this comment.
This check is unnecessary.
go.mod1
Outdated
| @@ -11,6 +11,7 @@ require ( | |||
| github.com/pingcap/errors v0.11.0 | |||
| github.com/pingcap/tidb v0.0.0-20190218065808-69472bd1a6e9 | |||
| github.com/pingcap/tipb v0.0.0-20190107072121-abbec73437b7 | |||
| github.com/shirou/gopsutil v2.18.12+incompatible // indirect | |||
|
fixed @kennytm |
tiancaiamao
approved these changes
Mar 20, 2019
Merged
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
SET ROLEis an important part of RBAC function. Many other RBAC grammar rely onSET ROLE. The detail document forSET ROLEis here : https://dev.mysql.com/doc/refman/8.0/en/set-role.htmlWhat is changed and how it works?
Adding
RoleIdentityandSetRoleStmtforastpackage, which contain information about those role is going to be active.Check List
Tests
Code changes
Side effects