privilege, executor: add SET ROLE and CURRENT_ROLE support
#9581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Mar 7, 2019
privilege/privileges/cache.go
Outdated
| @@ -16,6 +16,7 @@ package privileges | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/pingcap/parser/auth" | |||
There was a problem hiding this comment.
Move this line to the third party libs part.
jackysp
reviewed
Mar 7, 2019
|
|
||
| // evalString evals a builtinCurrentUserSig. | ||
| // See https://dev.mysql.com/doc/refman/5.7/en/information-functions.html#function_current-user | ||
| func (b *builtinCurrentRoleSig) evalString(row chunk.Row) (string, bool, error) { |
There was a problem hiding this comment.
It is better to add some test cases for this built-in function.
Codecov Report
@@ Coverage Diff @@
## master #9581 +/- ##
================================================
- Coverage 67.1706% 67.1505% -0.0202%
================================================
Files 381 381
Lines 79956 80053 +97
================================================
+ Hits 53707 53756 +49
- Misses 21460 21504 +44
- Partials 4789 4793 +4 |
tiancaiamao
reviewed
Mar 12, 2019
|
/run-all-tests |
|
PTAL @tiancaiamao |
tiancaiamao
reviewed
Mar 18, 2019
executor/simple.go
Outdated
| } | ||
| e.done = true | ||
| return errors.Trace(err) | ||
| } | ||
|
|
||
| func (e *SimpleExec) executeSetRole(s *ast.SetRoleStmt) error { | ||
| checkDup := make(map[string]*auth.RoleIdentity) |
There was a problem hiding this comment.
make(map[string]*auth.RoleIdentity, len(s.RoleList))
go.mod
Outdated
| @@ -23,7 +23,7 @@ require ( | |||
| github.com/go-sql-driver/mysql v0.0.0-20170715192408-3955978caca4 | |||
| github.com/gogo/protobuf v1.2.0 // indirect | |||
| github.com/golang/groupcache v0.0.0-20181024230925-c65c006176ff // indirect | |||
| github.com/golang/protobuf v1.2.0 | |||
| github.com/golang/protobuf v1.3.0 | |||
There was a problem hiding this comment.
Why protobuf is changed here?
| @@ -104,12 +105,42 @@ type columnsPrivRecord struct { | |||
| patTypes []byte | |||
| } | |||
|
|
|||
| // RoleGraphEdgesTable is used to cache relationship between and role. | |||
| type roleGraphEdgesTable struct { | |||
| roleList map[string]bool | |||
There was a problem hiding this comment.
It's better to use roleList map[string]struct{} here
roleList map[string]struct{}
roleList["xx"] = struct{}{}
if _, ok := roleList["xx"] {
...
}
|
LGTM |
|
PTAL @jackysp |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support active role and
SET ROLE,CURRENT_ROLEfunction.What is changed and how it works?
Create an graph data structure to find relationship between role and user quickly, which is always update as other privilege tables. It will load
mysql.role_edgestable, and convert relationship to an graph.When we need to active some roles for current session, we need to check whether these roles has been granted for current user.
RoleGraphcan finish this task quickly.SET ROLEis just for set active role for current session, more detail: https://dev.mysql.com/doc/refman/8.0/en/set-role.htmlBecause
set default roleis not support yet. some gramma will be added soon.Check List
Tests
Code changes
Side effects