Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast, mysql: add window function flag and error message #76

Merged
merged 9 commits into from
Jan 3, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Dec 10, 2018

Add a flag to check if an expression contains window function, and add error messages for window function.

@alivxxx alivxxx added the type/enhancement New feature or request label Dec 10, 2018
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Dec 10, 2018
@zz-jason
Copy link
Member

@XuHuaiyu @winoros @eurekaka PTAL

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 11, 2018
@alivxxx alivxxx added the DNM label Dec 11, 2018
@alivxxx alivxxx removed the DNM label Jan 3, 2019
@alivxxx alivxxx merged commit c065c74 into pingcap:master Jan 3, 2019
@alivxxx alivxxx deleted the window branch January 3, 2019 07:59
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 LGT2 type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants