planner: support window function #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
sig/planner
winoros
reviewed
Dec 10, 2018
| @@ -0,0 +1,29 @@ | |||
| // Copyright 2018 PingCAP, Inc. | |||
There was a problem hiding this comment.
should it belong to aggregation?
There was a problem hiding this comment.
Change the package name to udf or something else?
There was a problem hiding this comment.
No need to, window function is also a kind of aggregate function.
There was a problem hiding this comment.
But its behavior is quite different with normal aggregate function since it won't make the rows grouped into one though there's OVER clause.
I think they should be in the same level not superior-subordinate.
zz-jason
reviewed
Dec 10, 2018
| @@ -0,0 +1,29 @@ | |||
| // Copyright 2018 PingCAP, Inc. | |||
There was a problem hiding this comment.
No need to, window function is also a kind of aggregate function.
zz-jason
reviewed
Dec 13, 2018
zz-jason
reviewed
Dec 26, 2018
zz-jason
reviewed
Dec 28, 2018
winoros
reviewed
Jan 2, 2019
|
PTAL @winoros |
eurekaka
reviewed
Jan 2, 2019
eurekaka
reviewed
Jan 3, 2019
eurekaka
added
status/LGT2
|
/run-all-tests |
|
/run-unit-test |
|
I updated the parser, PTAL @eurekaka |
eurekaka
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support the window function in planner.
What is changed and how it works?
Add logical and physical plan operator for window function. It resolves the name in window function before projection, and build the window funtion after processing the having clause. For partition by and order by clause in window functioin, it adds sort operator as it's child.
The named window and frame clause will be processed in next PR.
Check List
Tests
Code changes
Side effects
Related changes
PTAL @zz-jason @winoros @XuHuaiyu @eurekaka
This change is