Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect metrics for cdc, lightning and importer #2835

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Collect metrics for cdc, lightning and importer #2835

merged 3 commits into from
Jun 30, 2020

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

fix: #2786

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Collect metrics for TiCDC, TiDB Lightning and TiKV Importer

@Yisaer Yisaer added the area/monitor monitoring label Jun 30, 2020
DanielZhangQD
DanielZhangQD approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor

Yisaer commented Jun 30, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 935cddc into pingcap:master Jun 30, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jun 30, 2020
@weekface @ti-srebot
cherry pick pingcap#2835 to release-1.1
979db46 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2838

@weekface weekface deleted the metrics-for-cdc branch June 30, 2020 09:45
DanielZhangQD pushed a commit that referenced this pull request Jul 1, 2020
@ti-srebot @weekface
cherry pick #2835 to release-1.1 (#2838)
90e4b56 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: weekface <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
area/monitor monitoring CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TidbMonitor supports monitoring for lightning, importer, and cdc
4 participants
@weekface @Yisaer @ti-srebot @DanielZhangQD