Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect metrics for cdc, lightning and importer (#2835) #2838

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Collect metrics for cdc, lightning and importer (#2835) #2838

merged 1 commit into from
Jul 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2835 to release-1.1

What problem does this PR solve?

fix: #2786

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Collect metrics for TiCDC, TiDB Lightning and TiKV Importer

@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
@ti-srebot ti-srebot added this to the v1.1.2 milestone Jun 30, 2020
DanielZhangQD
DanielZhangQD approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 90e4b56 into pingcap:release-1.1 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@weekface weekface

Labels
area/monitor monitoring
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @DanielZhangQD @weekface