ebs br: pass region name for aws EBS volume operation #5195

BornChanger · 2023-07-21T11:36:22Z

What problem does this PR solve?

Close #5185

What is changed and how does it work?

Pass the region name for EBS volume delete and addtag operation.

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

BornChanger · 2023-07-21T11:36:58Z

/cc @WangLe1321 @csuzhangxc PTAL.

ti-chi-bot · 2023-07-21T11:37:00Z

@BornChanger: The label(s) /@wangle1321, /@csuzhangxc, /ptal. cannot be applied, because the repository doesn't have them.

In response to this:

/cc @WangLe1321 @csuzhangxc PTAL.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

codecov-commenter · 2023-07-21T11:53:58Z

Codecov Report

Merging #5195 (dcbd67b) into master (2aa655d) will decrease coverage by 10.26%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5195       +/-   ##
===========================================
- Coverage   57.99%   47.74%   -10.26%     
===========================================
  Files         245      208       -37     
  Lines       29228    27685     -1543     
===========================================
- Hits        16951    13217     -3734     
- Misses      10630    12898     +2268     
+ Partials     1647     1570       -77

Flag	Coverage Δ
e2e	`47.74% <0.00%> (?)`
unittest	`?`

BornChanger · 2023-07-22T00:56:17Z

/retest

BornChanger · 2023-07-22T05:47:31Z

/test pull-e2e-kind-br

ti-chi-bot · 2023-07-22T05:47:33Z

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-22T05:47:33Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-23T03:58:01Z

/test pull-e2e-kind-br

ti-chi-bot · 2023-07-23T03:58:04Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-23T03:58:04Z

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-23T03:59:55Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test chaos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-23T04:01:08Z

@BornChanger: The label(s) /chaos cannot be applied, because the repository doesn't have them.

In response to this:

/test chaos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BornChanger · 2023-07-23T04:54:43Z

/test pull-e2e-kind-basic

ti-chi-bot · 2023-07-23T04:54:45Z

@BornChanger: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-23T04:54:45Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-24T02:28:11Z

/test pull-e2e-kind-tikv-scale-simultaneously

ti-chi-bot · 2023-07-24T02:28:13Z

@BornChanger: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-24T02:28:13Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/backup/restore/restore_manager.go

Signed-off-by: BornChanger <[email protected]>

BornChanger · 2023-07-24T16:09:35Z

/test pull-e2e-kind-br pull-e2e-kind-basic

ti-chi-bot · 2023-07-24T16:09:37Z

@BornChanger: The label(s) /pull-e2e-kind-br, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-24T16:09:37Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-24T17:10:40Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

ti-chi-bot · 2023-07-24T17:10:43Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-24T17:10:43Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-25T02:10:38Z

/test pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-07-25T02:10:40Z

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-25T02:10:40Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-25T04:47:41Z

/test pull-e2e-kind-serial

ti-chi-bot · 2023-07-25T04:47:42Z

@BornChanger: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-25T04:47:43Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-25T07:12:04Z

/chery-pick release-1.5

ti-chi-bot · 2023-07-25T07:12:07Z

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/chery-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-25T07:12:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-07-25T07:12:35Z

[LGTM Timeline notifier]

Timeline:

2023-07-25 07:12:35.420231077 +0000 UTC m=+252098.014762050: ☑️ agreed by WangLe1321.

csuzhangxc · 2023-07-25T07:26:19Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-25T07:26:21Z

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-25T07:27:10Z

@csuzhangxc: new pull request created to branch release-1.5: #5197.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: BornChanger <[email protected]> Co-authored-by: BornChanger <[email protected]>

ti-chi-bot bot requested a review from lichunzhu July 21, 2023 11:36

ti-chi-bot bot added the size/S label Jul 21, 2023

BornChanger requested review from WangLe1321 and csuzhangxc July 21, 2023 11:38

pingcap deleted a comment from ti-chi-bot bot Jul 23, 2023

WangLe1321 reviewed Jul 24, 2023

View reviewed changes

pkg/backup/restore/restore_manager.go Outdated Show resolved Hide resolved

*: fill regionName for EBS/EC2 api when needed

13f81d1

Signed-off-by: BornChanger <[email protected]>

BornChanger force-pushed the ebs_api_with_region branch from 02fff6e to 13f81d1 Compare July 24, 2023 10:27

pkg: fix import order

06e15e4

Signed-off-by: BornChanger <[email protected]>

ti-chi-bot bot added size/M and removed size/S labels Jul 24, 2023

pkg: fix ut

d9e7c64

Signed-off-by: BornChanger <[email protected]>

pkg: code format

dcbd67b

Signed-off-by: BornChanger <[email protected]>

BornChanger requested a review from WangLe1321 July 24, 2023 16:08

BornChanger mentioned this pull request Jul 24, 2023

EBS BR support to multiple k8s cluster TiDB #5003

Open

WangLe1321 approved these changes Jul 25, 2023

View reviewed changes

ti-chi-bot bot added the lgtm label Jul 25, 2023

ti-chi-bot bot added the approved label Jul 25, 2023

ti-chi-bot bot merged commit 34c19d4 into pingcap:master Jul 25, 2023
5 checks passed

ti-chi-bot mentioned this pull request Jul 25, 2023

ebs br: pass region name for aws EBS volume operation (#5195) #5197

Merged

10 tasks

csuzhangxc pushed a commit that referenced this pull request Jul 26, 2023

ebs br: pass region name for aws EBS volume operation (#5195) (#5197)

674fb8a

Signed-off-by: BornChanger <[email protected]> Co-authored-by: BornChanger <[email protected]>

BornChanger added type/cherry-pick-for-release-1.5 area/ebs-br labels Jul 28, 2023

ebs br: pass region name for aws EBS volume operation #5195

ebs br: pass region name for aws EBS volume operation #5195

Conversation

BornChanger commented Jul 21, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

BornChanger commented Jul 21, 2023

ti-chi-bot bot commented Jul 21, 2023

codecov-commenter commented Jul 21, 2023 • edited Loading

Codecov Report

BornChanger commented Jul 22, 2023

BornChanger commented Jul 22, 2023

ti-chi-bot bot commented Jul 22, 2023

ti-chi-bot bot commented Jul 22, 2023

BornChanger commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

BornChanger commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

ti-chi-bot bot commented Jul 23, 2023

BornChanger commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

BornChanger commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

BornChanger commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

ti-chi-bot bot commented Jul 24, 2023

BornChanger commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

BornChanger commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

BornChanger commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

[LGTM Timeline notifier]

csuzhangxc commented Jul 25, 2023

ti-chi-bot bot commented Jul 25, 2023

ti-chi-bot commented Jul 25, 2023

codecov-commenter commented Jul 21, 2023 •

edited

Loading