Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: pass region name for aws EBS volume operation (#5195) #5197

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5195

What problem does this PR solve?

Close #5185

What is changed and how does it work?

Pass the region name for EBS volume delete and addtag operation.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign azurezyq for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #5197 (c7b84b4) into release-1.5 (2d5ac5f) will increase coverage by 7.72%.
The diff coverage is 14.28%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5197      +/-   ##
===============================================
+ Coverage        57.95%   65.67%   +7.72%     
===============================================
  Files              248      252       +4     
  Lines            29331    32759    +3428     
===============================================
+ Hits             16998    21516    +4518     
+ Misses           10685     9522    -1163     
- Partials          1648     1721      +73     
Flag Coverage Δ
e2e 48.20% <0.00%> (?)
unittest 57.94% <14.28%> (-0.01%) ⬇️

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-br
/test pull-e2e-kind-tngm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-br, /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-br
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial, /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc enabled auto-merge (squash) July 25, 2023 09:45
@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 26, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc merged commit 674fb8a into pingcap:release-1.5 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants