Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: fail delete cr operation if backup meta is missing #5199

Merged

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jul 25, 2023

What problem does this PR solve?

Closes #5196
Closes #5159

What is changed and how does it work?

If backup meta file doesn't exist during backup cr deletion, we should fail the backup cr deletion and remind users to do manual snapshots deletion.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 July 25, 2023 09:43
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu July 25, 2023 09:43
@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #5199 (bfdbe6b) into master (34c19d4) will increase coverage by 1.90%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5199      +/-   ##
==========================================
+ Coverage   57.97%   59.87%   +1.90%     
==========================================
  Files         245      248       +3     
  Lines       29240    32534    +3294     
==========================================
+ Hits        16951    19480    +2529     
- Misses      10641    11302     +661     
- Partials     1648     1752     +104     
Flag Coverage Δ
e2e 24.35% <ø> (?)
unittest 57.95% <0.00%> (-0.03%) ⬇️

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 25, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/retest

@csuzhangxc csuzhangxc merged commit 87b2874 into pingcap:master Jul 28, 2023
5 checks passed
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5210.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants