Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not delete chaos-mesh namespace #5246

Closed
wants to merge 1 commit into from

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Aug 16, 2023

chaos testing hasn't been working for a long time, so we disable this Action now and may enable it again (and make it work) later.

  • the chaos YAML has pingcap namespace, but this namespace will be cleaned in
    if framework.TestContext.CleanStart {
    reservedNamespaces := []string{
    metav1.NamespaceSystem,
    metav1.NamespaceDefault,
    metav1.NamespacePublic,
    v1.NamespaceNodeLease,
    }
    if framework.TestContext.Provider == "kind" {
    // kind local path provisioner namespace since 0.7.0
    // https://github.com/kubernetes-sigs/kind/blob/v0.7.0/pkg/build/node/storage.go#L35
    reservedNamespaces = append(reservedNamespaces, "local-path-storage")
    } else if framework.TestContext.Provider == "openshift" {
    reservedNamespaces = append(reservedNamespaces, "openshift")
    }
    deleted, err := framework.DeleteNamespaces(c, nil, reservedNamespaces)
    if err != nil {
    log.Failf("Error deleting orphaned namespaces: %v", err)
    }
    // try to clean up backups
    if err := ForceCleanBackups(c, extClient, apiExtClient); err != nil {
    log.Failf("Error clean backups: %v", err)
    }
    log.Logf("Waiting for deletion of the following namespaces: %v", deleted)
    if err := framework.WaitForNamespacesDeleted(c, deleted, framework.DefaultNamespaceDeletionTimeout); err != nil {
    log.Failf("Failed to delete orphaned namespaces %v: %v", deleted, err)
    }
    }
  • the ginkgo focus for chaos mesh is Restarter (https://github.com/pingcap/tidb-operator/blob/27e71c73f50152da6222322650c4f6de405d1165/.github/workflows/chaos.yaml#L60C52-L60C61), but this case has been removed in Remove the PodRestarter controller and tidb.pingcap.com/pod-defer-deleting annotation #3296

@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge August 16, 2023 07:13
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 16, 2023
@csuzhangxc csuzhangxc closed this Aug 16, 2023
@csuzhangxc csuzhangxc deleted the chaos branch August 16, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant