-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs br: enhance TC validation #5659
Conversation
/cc @WangLe1321 |
Signed-off-by: BornChanger <[email protected]>
be2db8d
to
036ba16
Compare
/cc @YuJuncen |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
/run-pull-e2e-kind-br |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5659 +/- ##
===========================================
- Coverage 61.46% 21.07% -40.39%
===========================================
Files 235 219 -16
Lines 30397 30427 +30
===========================================
- Hits 18683 6412 -12271
- Misses 9840 23103 +13263
+ Partials 1874 912 -962
|
/cherry-pick release-1.5 |
/cherry-pick release-1.6 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Closes #5658
What is changed and how does it work?
For volume backup, this PR enhances the validation against the target TiDB cluster. That is if there is no TiKV stores or TiKV replica number is 0, the backup will fail.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.