Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: enhance TC validation #5659

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jun 6, 2024

What problem does this PR solve?

Closes #5658

What is changed and how does it work?

For volume backup, this PR enhances the validation against the target TiDB cluster. That is if there is no TiKV stores or TiKV replica number is 0, the backup will fail.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@BornChanger
Copy link
Contributor Author

/cc @WangLe1321

@ti-chi-bot ti-chi-bot bot requested a review from WangLe1321 June 6, 2024 12:39
@BornChanger
Copy link
Contributor Author

/cc @YuJuncen

@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen June 6, 2024 12:43
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-06 13:17:54.593965874 +0000 UTC m=+38628.647277797: ☑️ agreed by WangLe1321.
  • 2024-06-09 12:28:29.346139988 +0000 UTC m=+294863.399451913: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2024

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (3897095) to head (f044720).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5659       +/-   ##
===========================================
- Coverage   61.46%   21.07%   -40.39%     
===========================================
  Files         235      219       -16     
  Lines       30397    30427       +30     
===========================================
- Hits        18683     6412    -12271     
- Misses       9840    23103    +13263     
+ Partials     1874      912      -962     
Flag Coverage Δ
e2e 21.07% <33.33%> (?)
unittest ?

@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5662.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5663.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants