Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: enhance TC validation (#5659) #5663

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5659

What problem does this PR solve?

Closes #5658

What is changed and how does it work?

For volume backup, this PR enhances the validation against the target TiDB cluster. That is if there is no TiKV stores or TiKV replica number is 0, the backup will fail.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign niubell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.6@27d419c). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.6    #5663   +/-   ##
==============================================
  Coverage               ?   61.48%           
==============================================
  Files                  ?      246           
  Lines                  ?    34585           
  Branches               ?        0           
==============================================
  Hits                   ?    21266           
  Misses                 ?    11322           
  Partials               ?     1997           
Flag Coverage Δ
e2e 21.04% <33.33%> (?)
unittest 61.48% <100.00%> (?)

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind-br

@csuzhangxc csuzhangxc merged commit f46dbc0 into pingcap:release-1.6 Jun 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants