Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add design doc for rule based index selection #27223

Merged

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Aug 14, 2021

What problem does this PR solve?

Issue Number: close #27227

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2021
@tisonkun
Copy link
Contributor

/cc @winoros

@tisonkun
Copy link
Contributor

tisonkun commented Aug 18, 2021

/cc @bb7133 @yudongusa

I think this proposal may require a release note as user should be aware that we improve performance in several scenarios notably.

@winoros
Copy link
Member

winoros commented Sep 2, 2021

@tisonkun Release note has contained this one.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Sep 7, 2021

/uncc @bb7133 @yudongusa

/cc @rebelice @qw4990

Please take a look at the late design document. Thanks!

@ti-chi-bot ti-chi-bot requested review from qw4990 and rebelice and removed request for bb7133 and yudongusa September 7, 2021 05:29
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2021
@tisonkun
Copy link
Contributor

@winoros @qw4990 could you please help on merging this PR?

@winoros
Copy link
Member

winoros commented Sep 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d69699d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 70e4d5d into pingcap:master Sep 18, 2021
@xuyifangreeneyes xuyifangreeneyes deleted the rule-based-index-sel-design-doc branch October 30, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create proposal of heuristic rules enhancement for index selection
5 participants