Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test for Top SQL #33208

Closed
crazycs520 opened this issue Mar 17, 2022 · 0 comments · Fixed by #33623
Closed

Add more test for Top SQL #33208

crazycs520 opened this issue Mar 17, 2022 · 0 comments · Fixed by #33623
Assignees
@crazycs520
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@crazycs520
Copy link
Contributor

Enhancement

We need add some test to make sure we can find some unknow SQL is not tracked by TopSQL, some idea is:

  • check all RPC request should been set tag.
    • this may should also need check the RPC key range, only check the table range, since some RPC is not cause by SQL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazycs520 crazycs520

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

topsql: add more test to check resource tag for each RPC request crazycs520/tidb
1 participant
@crazycs520