topsql: fix the issue of TiDB doesn't set the request tag for DDL before send RPC request to TiKV

[crazycs520]

What problem does this PR solve?

Issue Number: close #33132

Problem Summary: This PR fix the issue of TiDB doesn't set the request tag for DDL before send rpc to TiKV.

What is changed and how it works?

Set the DDL request tag.

Other problem: After this PR, TopSQL still doesn't contain the scan_row/scan_index data , I will fix this in next PR.

Check List

Tests

• Manual test (add detailed scripts or steps below)

1. create a table and insert 10000000 rows data.

CREATE TABLE `t_full_table_scan` (
  `a` bigint(20) NOT NULL,
  `b` bigint(20) DEFAULT NULL,
  `c` timestamp(6) NULL DEFAULT NULL,
  `d` varchar(100) DEFAULT NULL,
  `e` decimal(30,8) DEFAULT NULL,
  PRIMARY KEY (`a`)
);

3. execute following DDL:

alter table t_full_table_scan add index idx2 (c,d,b);
alter table t_full_table_scan modify column e decimal(30, 8);

4. check the topsql UI in tidb-dashboard.

TiDB:

TiKV:

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• breeswish
• zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/97c97ca59652d30f55016a678534ba74c16aa15b

[crazycs520]

/run-all-tests

[breezewish]

How about checkExist for all requests happened in the test suite? In this way, when there are new kind of requests, it will be caught.

[zhongzc]

I have a similar thought: require all requests to contain tags.

[crazycs520]

Not all RPC requests are caused by SQL. So I can't check the all request. But maybe I can check the ALL cop kind RPC request, since as I know, cop kind request must cause by SQL.

[breezewish]

Instead of using white allow list that only checks cop requests, maybe we can use black block lists to check all requests except for some kinds. In this way, when there are new kind of RPC requests, people must review, check and change the test case in order to pass CI. Is this possible?

[crazycs520]

I will refine this test in this issue later. #33208

[breezewish]

This PR should not close #33132 since it does not fully resolve the issue.

[crazycs520]

This PR should not close #33132 since it does not fully resolve the issue.

Great, I already changed the issue description.

[breezewish]

This PR should not close #33132 since it does not fully resolve the issue.

Great, I already changed the issue description.

@crazycs520 This is a nice workaround. Just remember to also fix remaining problems. You may like to open new issues to track them.

[crazycs520]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 80ccb7d

[crazycs520]

/merge

[ti-srebot]

cherry pick to release-5.4 in PR #33210

[ti-srebot]

cherry pick to release-6.0 failed