Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: auto resume from connection error #33363

Closed
sleepymole opened this issue Mar 24, 2022 · 2 comments · Fixed by #33510
Closed

lightning: auto resume from connection error #33363

sleepymole opened this issue Mar 24, 2022 · 2 comments · Fixed by #33510
Assignees
@buchuitoudegou
Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@sleepymole
Copy link
Contributor

Enhancement

Don't record connection error to checkpoint, so that Lightning can resume automatically. Connection error is usually recoverable error. It doesn't cause any data corruption. So it is safe to resume Lightning without any other operations.
@sleepymole sleepymole added the type/enhancement The issue or PR belongs to an enhancement. label Mar 24, 2022
@sleepymole
Copy link
Contributor Author

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Mar 24, 2022
@niubell
Copy link
Contributor

niubell commented Mar 28, 2022

/assign buchuitoudegou

@buchuitoudegou buchuitoudegou mentioned this issue Mar 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 29, 2022
@buchuitoudegou
lightning: auto resume from recoverable error (#33510)
762ae26 
close #33363
@buchuitoudegou buchuitoudegou mentioned this issue Apr 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buchuitoudegou buchuitoudegou

Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: auto resume from recoverable error buchuitoudegou/tidb
4 participants
@niubell @sleepymole @buchuitoudegou @ti-chi-bot