Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: auto resume from recoverable error #33510

Merged
merged 7 commits into from
Mar 29, 2022
Merged

lightning: auto resume from recoverable error #33510

merged 7 commits into from
Mar 29, 2022

Conversation

buchuitoudegou
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #33363

Problem Summary:

What is changed and how it works?

Ignoring recoverable errors before writing checkpoints.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@buchuitoudegou
Copy link
Contributor Author

/cc @gozssky
/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@sleepymole
Copy link
Contributor

/cc @glorv PTAL

@ti-chi-bot
Copy link
Member

@gozssky: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @glorv PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from glorv March 28, 2022 10:19
@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7df870d5f12f7f392dadc05b0f5978c130902fe1

@buchuitoudegou
Copy link
Contributor Author

/cc @D3Hunter

@glorv
Copy link
Contributor

glorv commented Mar 28, 2022

Please add a unit test

glorv
glorv reviewed Mar 28, 2022
View reviewed changes
br/pkg/lightning/restore/restore.go Outdated
@@ -975,6 +975,11 @@ func (rc *Controller) saveStatusCheckpoint(ctx context.Context, tableName string
case !common.IsContextCanceledError(err):
merger.SetInvalid()
rc.errorSummaries.record(tableName, err, statusIfSucceed)
case utils.IsRetryableError(err), utils.MessageIsRetryableStorageError(err.Error()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will most of these case be catched by !common.IsContextCanceledError(err) ?

D3Hunter
D3Hunter reviewed Mar 28, 2022
View reviewed changes
br/pkg/lightning/restore/restore.go Outdated
@@ -975,6 +975,11 @@ func (rc *Controller) saveStatusCheckpoint(ctx context.Context, tableName string
case !common.IsContextCanceledError(err):
merger.SetInvalid()
rc.errorSummaries.record(tableName, err, statusIfSucceed)
case utils.IsRetryableError(err), utils.MessageIsRetryableStorageError(err.Error()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this case should move before case !common.IsContextCanceledError(err):, else it's never run

br/pkg/lightning/restore/restore.go Outdated
case utils.IsRetryableError(err), utils.MessageIsRetryableStorageError(err.Error()):
// recoverable error, should not be recorded in checkpoint
// which will prevent lightning from automatically recovering
rc.errorSummaries.record(tableName, err, statusIfSucceed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we record this error? since it's recoverable

errorSummaries is emitted after controller.Run.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2022
@sleepymole
Copy link
Contributor

@D3Hunter @glorv PTAL again, thanks

D3Hunter
D3Hunter reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sleepymole
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d216f58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2022
@ti-chi-bot
Copy link
Member

@buchuitoudegou: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 762ae26 into pingcap:master Mar 29, 2022
@sleepymole sleepymole mentioned this pull request Mar 31, 2022
Merged
2 tasks
@D3Hunter D3Hunter mentioned this pull request Apr 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@glorv glorv glorv left review comments

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: auto resume from connection error
6 participants
@buchuitoudegou @ti-chi-bot @sleepymole @sre-bot @glorv @D3Hunter