exchange partition will fail when table has placement policy and then insert will fail forever

[lcwangchao]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

CREATE PLACEMENT POLICY rule1 FOLLOWERS=4;
CREATE TABLE `t1` (
  `date` date NOT NULL ,
  `name` varchar(10)  NOT NULL,
  UNIQUE KEY `uk_1` (`date`,`name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin PLACEMENT POLICY=`rule1`;


CREATE TABLE `t1_partition` (
  `date` date NOT NULL ,
  `name` varchar(10)  NOT NULL,
  UNIQUE KEY `uk_1` (`date`,`name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin  PLACEMENT POLICY=`rule1`
PARTITION BY RANGE COLUMNS(`date`)
(PARTITION `p202307` VALUES LESS THAN ('2023-08-01'),
 PARTITION `p202308` VALUES LESS THAN ('2023-09-01'),
 PARTITION `p202309` VALUES LESS THAN ('2023-10-01'),
 PARTITION `p202310` VALUES LESS THAN ('2023-11-01'),
 PARTITION `p202311` VALUES LESS THAN ('2023-12-01'),
 PARTITION `p202312` VALUES LESS THAN ('2024-01-01'),
 PARTITION `pfuture` VALUES LESS THAN (MAXVALUE));

alter table t1_partition exchange partition p202307 with table t1; -- this query will fail
insert into t1(date, name) values ("2023-08-06","0000"); -- then this insert will fail too

2. What did you expect to see? (Required)

no error

3. What did you see instead (Required)

TiDB [email protected]:test> alter table t1_partition exchange partition p202307 with table t1;
(1736, 'Tables have different definitions')

TiDB [email protected]:test> insert into t1(date, name) values ("2023-08-06","0000");
(1748, 'Found a row not matching the given partition set')

4. What is your TiDB version? (Required)

master, but I think it affects TiDB after v5.4.0

[lcwangchao]

It may be introduced by this PR: #35749

1. It will check whether the partition and table's placement settings match. However, the case that partition's placement settings are inherited from the parent table is not considered.
2. When the placement check fails, the DDL job will also fail. But the intermediate meta is not rollbacked and an error: "Found a row not matching the given partition set" will be returned when doing insert because the meta is corrupted

[seiya-annie]

/found community