-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Exchange part schema load fix #46126
ddl: Exchange part schema load fix #46126
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46126 +/- ##
================================================
- Coverage 74.7667% 72.6746% -2.0921%
================================================
Files 1292 1304 +12
Lines 398141 400460 +2319
================================================
- Hits 297677 291033 -6644
- Misses 81100 90938 +9838
+ Partials 19364 18489 -875
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-issue-triage-complete |
@mjonss: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
�LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/merge |
@bb7133: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
This reverts commit f574f79.
What problem does this PR solve?
Issue Number: ref #46125 close #45791
Problem Summary:
What is changed and how it works?
Check List
Tests
Manual test:
Build this PR and use it for starting a cluster
tiup playground --db.binpath ./bin/tidb-server
and then run tiflash test
sh run-test.sh fullstack-test2/ddl/alter_exchange_partition.test
which no longer failsAlso check the tidb.log that there are no failures loading new schema diffs, so no full schema reloads are needed.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
(Unless 7.4 get released without this fix).