Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot Restore: CoarseGrained completely replaces FineGrained #52877

Closed
3 tasks done
Leavrth opened this issue Apr 25, 2024 · 1 comment
Closed
3 tasks done

Snapshot Restore: CoarseGrained completely replaces FineGrained #52877

Leavrth opened this issue Apr 25, 2024 · 1 comment
Assignees
@Leavrth
Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Apr 25, 2024 •
edited
Loading

Enhancement

Step 1 - Adjust the file directory structure

  1. [release-8.2] There are too many files in the path br/pkg/restore. However, each file contains many struct, and imports each other.
  1. Separate the snap restore client and log restore client. And remove the FineGrained configure in the internal code.
  1. add more unit tests to cover more functions in br/pkg/restore.
  1. Since we doesn't use FineGrained snapshot restore, we can clean much codes.
    4.1. Simplify CreateTables. br: clean codes -- simplify the CreateTable stage #55274
    4.2. Simplify split & scatter and download & ingest. br: clean codes -- restore tables #55519
@Leavrth Leavrth added type/enhancement The issue or PR belongs to an enhancement. component/br This issue is related to BR of TiDB. labels Apr 25, 2024
@Leavrth Leavrth self-assigned this Apr 25, 2024
@Leavrth Leavrth mentioned this issue Apr 28, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 30, 2024
@Leavrth
br: adjust file directory br/pkg/restore (#52944)
7481aa6 
ref #52877
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue May 7, 2024
@Leavrth @3AceShowHand
br: adjust file directory br/pkg/restore (pingcap#52944)
5e42826 
ref pingcap#52877
@Leavrth Leavrth mentioned this issue May 11, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2024
@Leavrth
br: separate the restore client (#53197)
1c4a9c6 
ref #52877
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
@Leavrth @terry1purcell
br: separate the restore client (pingcap#53197)
00cb740 
ref pingcap#52877
@Leavrth Leavrth mentioned this issue May 22, 2024
Merged
13 tasks
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@Leavrth @RidRisR
br: separate the restore client (pingcap#53197)
8c580ce 
ref pingcap#52877
ti-chi-bot bot pushed a commit that referenced this issue Jun 18, 2024
@Leavrth
br: add unit test for restore pkg (#53477)
4af494f 
ref #52877
@BornChanger
Copy link
Contributor

done

This was referenced Aug 7, 2024
Closed
Merged
@Leavrth Leavrth mentioned this issue Aug 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 20, 2024
@Leavrth
br: clean codes -- simplify the CreateTable stage (#55274)
ed9aa18 
ref #52877
ti-chi-bot bot pushed a commit that referenced this issue Aug 26, 2024
@Leavrth
br: clean codes -- restore tables (#55519)
4eeeef8 
ref #52877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leavrth Leavrth

Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Leavrth @BornChanger