-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add unit test for restore pkg #53477
br: add unit test for restore pkg #53477
Conversation
Signed-off-by: Jianjun Liao <[email protected]>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jianjun Liao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53477 +/- ##
=================================================
- Coverage 72.4404% 57.9224% -14.5180%
=================================================
Files 1507 1665 +158
Lines 430584 632052 +201468
=================================================
+ Hits 311917 366100 +54183
- Misses 99367 241560 +142193
- Partials 19300 24392 +5092
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jianjun Liao <[email protected]>
/retest |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jianjun Liao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: Jianjun Liao <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/ok-to-test |
/retest |
1 similar comment
/retest |
@Leavrth: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #52877
Problem Summary:
add unit test for restore pkg
What changed and how does it work?
add unit test for restore pkg
utiltest
to implement the public fake client used for unit test.restore
package internal sub-packages, such asimport client
,split client
,db
and some util codes.log client
andsnap client
pakcages.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.