Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add unit test for restore pkg #53477

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented May 22, 2024

What problem does this PR solve?

Issue Number: ref #52877

Problem Summary:
add unit test for restore pkg

What changed and how does it work?

add unit test for restore pkg

  1. introduce a new package utiltest to implement the public fake client used for unit test.
  2. add more unit tests to cover the restore package internal sub-packages, such as import client, split client, db and some util codes.
  3. add more unit tests for log client and snap client pakcages.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels May 22, 2024
Copy link

tiprow bot commented May 22, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <[email protected]>
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 92.92929% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.9224%. Comparing base (97aac23) to head (ccaffc5).
Report is 121 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53477         +/-   ##
=================================================
- Coverage   72.4404%   57.9224%   -14.5180%     
=================================================
  Files          1507       1665        +158     
  Lines        430584     632052     +201468     
=================================================
+ Hits         311917     366100      +54183     
- Misses        99367     241560     +142193     
- Partials      19300      24392       +5092     
Flag Coverage Δ
integration 39.8260% <7.6923%> (?)
unit 72.3858% <92.9292%> (+0.9618%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-1.0302%) ⬇️
parser ∅ <ø> (∅)
br 61.7275% <92.9292%> (+20.2691%) ⬆️

@Leavrth
Copy link
Contributor Author

Leavrth commented May 28, 2024

/retest

Copy link

tiprow bot commented May 28, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2024
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/restore/internal/log_split/sum_sorted_test.go Outdated Show resolved Hide resolved
br/pkg/restore/internal/log_split/split_test.go Outdated Show resolved Hide resolved
br/pkg/restore/snap_client/import_test.go Outdated Show resolved Hide resolved
Signed-off-by: Jianjun Liao <[email protected]>
Copy link

ti-chi-bot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 08:49:24.001913489 +0000 UTC m=+3457517.759049082: ☑️ agreed by BornChanger.
  • 2024-06-18 02:11:43.021287787 +0000 UTC m=+80829.506776617: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 18, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 18, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 18, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 18, 2024

/retest

Copy link

tiprow bot commented Jun 18, 2024

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test ccaffc5 link true /test tidb_parser_test
fast_test_tiprow ccaffc5 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 4af494f into pingcap:master Jun 18, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants