-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[goleveldb] panic: runtime error: invalid memory address or nil pointer dereference #57
Comments
May I have your command log? Thanks for your report! I will work on this. |
@shenli, please And then
|
@lunny please check the latest code and have a test. Thanks! |
Runtime here too, just updated my tidb:
|
The similar problem here.
|
@lunny I find a potential bug in go-xorm/tests I find an error when run test. Adding "engine.DropTables(&Deleted{})" before "engine.CreateTables(&Deleted{})" will fix it. Please take a look. Thanks! |
I have fixed this on go-xorm/tests@811ef5c. But there are still panics. @shenli |
Hi @lunny We create a branch to fix the panic, could you help us to check with it? The branch is https://github.com/pingcap/tidb/tree/siddontang/fix-driver-panic |
I have run
This is occupied on the |
@shenli is fixing it. |
Yes. no panic this time. It works well. If @shenli fix that. All the xorm tests will be passed. |
TiDB support "select for update". But there are tiny difference between TiDB and MySQL. There are some details in Wikipedia: OCC is generally used in environments with low data contention. When conflicts are rare, transactions can complete without the expense of managing locks and without having transactions wait for other transactions' locks to clear, leading to higher throughput than other concurrency control methods. However, if contention for data resources is frequent, the cost of repeatedly restarting transactions hurts performance significantly; it is commonly thought that other concurrency control methods have better performance under these conditions. However, locking-based ("pessimistic") methods also can deliver poor performance because locking can drastically limit effective concurrency even when deadlocks are avoided. Contents [hide] This section does not cite any references or sources. Please help improve this section by adding citations to reliable sources. Unsourced material may be challenged and removed. (August 2010) Begin: Record a timestamp marking the transaction's beginning. |
@lunny User may retry transaction when commit "select for update" failed. |
@ngaut OK. Then we can ignore the |
go-xorm/tests@999772a, I think maybe you can merge branch |
* mydump/reader: ensure we can't seek beyond EOF * *: enable `make test` and ensure all test cases can be compiled * vendor: update vendor In glide we removed the -s and -u flags since they are on by default, and removed --skip-test so that github.com/pingcap/check can be vendored. * makefile: define every test as integration test until TOOL-308 is fixed
BR closes domain before shutdown, so that it does not affect TiDB DDL workers. Signed-off-by: Neil Shen <[email protected]>
* add noData\noSchemas cli parameters * add noData\noSchemas cli parameters * add noData\noSchemas cli parameters
Signed-off-by: disksing <[email protected]>
When I try to delete, it panic.
The text was updated successfully, but these errors were encountered: