tidb: Fix panic in driverStmt.Query #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepared statement maybe not query, so the resultset maybe nil.
| c.Assert(err, IsNil) | ||
| _, err = db.Exec("insert into t values (1), (2), (3)") | ||
| c.Assert(err, IsNil) | ||
| _, err = db.Query("delete from `t` where `c` = ?", 1) |
There was a problem hiding this comment.
Query should returns an empty row for delete.
Address comment
Address comment
1. Close() 2. Call Next() two times
|
PTAL |
|
should this can fix #57 ? |
| @@ -379,6 +388,9 @@ func newdriverRows(rs rset.Recordset) *driverRows { | |||
| // result is inferred from the length of the slice. If a particular column | |||
| // name isn't known, an empty string should be returned for that entry. | |||
| func (r *driverRows) Columns() []string { | |||
| if r.rs == nil { | |||
| return make([]string, 0) | |||
There was a problem hiding this comment.
if return an empty slice, using []string{} is better?
There was a problem hiding this comment.
I am not sure. I think return empty array is better than nil.
|
I am not sure. I run go-xorm tidb test with another error. So I can not reach the panic point the same as lunny. |
|
LGTM |
shenli
added a commit
that referenced
this pull request
Sep 8, 2015
tidb: Fix panic in driverStmt.Query
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
… duration (pingcap#63) * restore: extend the closeWithRetry() wait duration to 30 seconds * kv-deliver: properly close the write stream before recyling the client
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
* impl Restore of ColunmNameExpr
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
* impl Restore of ColunmNameExpr
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
* impl Restore of ColunmNameExpr
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: disksing <[email protected]>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 6, 2024
…pingcap#51449) (pingcap#51) (pingcap#63) close pingcap#51448 Co-authored-by: 山岚 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prepared statement maybe not query, so the resultset maybe nil.