Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: replace logger with zap logger (#9521) #10043

Merged
merged 2 commits into from
Apr 4, 2019
Merged

executor: replace logger with zap logger (#9521) #10043

merged 2 commits into from
Apr 4, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Apr 4, 2019

Cherry pick #9521

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution type/2.1 cherry-pick labels Apr 4, 2019
zz-jason
zz-jason reviewed Apr 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 4, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Apr 4, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

jackysp
jackysp approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit e87c6f1 into pingcap:release-2.1 Apr 4, 2019
@alivxxx alivxxx deleted the log branch April 4, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @jackysp @zz-jason