executor: replace logger with zap logger #9521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/enhancement
|
/rebuild |
qw4990
reviewed
Mar 5, 2019
crazycs520
reviewed
Mar 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #9521 +/- ##
================================================
- Coverage 67.3389% 67.3334% -0.0055%
================================================
Files 378 378
Lines 79535 79540 +5
================================================
- Hits 53558 53557 -1
- Misses 21194 21201 +7
+ Partials 4783 4782 -1 |
zz-jason
reviewed
Mar 12, 2019
executor/admin.go
Outdated
| @@ -393,8 +395,9 @@ func (e *RecoverIndexExec) batchMarkDup(txn kv.Transaction, rows []recoverRows) | |||
| } | |||
|
|
|||
| if handle != rows[i].handle { | |||
| log.Warnf("[recover-index] The constraint of unique index:%v is broken, handle:%v is not equal handle:%v with idxKey:%v.", | |||
| e.index.Meta().Name.O, handle, rows[i].handle, key) | |||
| log.Warn("The constraint of unique index is broken when recovering index", | |||
There was a problem hiding this comment.
Should we print [recover-index] prefix? @zimulala What's your opinion?
XuHuaiyu
reviewed
Mar 13, 2019
XuHuaiyu
added
status/LGT2
eurekaka
reviewed
Mar 14, 2019
Co-Authored-By: lamxTyler <[email protected]>
|
/run-all-tests |
zz-jason
approved these changes
Mar 14, 2019
lysu
reviewed
Mar 15, 2019
| @@ -390,13 +390,11 @@ func (a *ExecStmt) LogSlowQuery(txnTS uint64, succ bool) { | |||
| } | |||
| execDetail := sessVars.StmtCtx.GetExecDetails() | |||
| if costTime < threshold { | |||
| if logutil.SlowQueryLogger.IsLevelEnabled(log.DebugLevel) { | |||
There was a problem hiding this comment.
It is already guaranteed by https://github.com/pingcap/tidb/pull/9521/files#diff-350127760839dbfd52d23927f7ff2d95R374.
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Apr 4, 2019
jackysp
pushed a commit
that referenced
this pull request
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Unify log format in package
executor.What is changed and how it works?
Replace log package with zap logger and follow the new log format.
Check List
Tests
Code changes
Side effects
Related changes