stats: fix the index cm sketch for fast analyze #10839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10839 +/- ##
================================================
- Coverage 81.0684% 80.9174% -0.1511%
================================================
Files 419 419
Lines 88894 88793 -101
================================================
- Hits 72065 71849 -216
- Misses 11600 11709 +109
- Partials 5229 5235 +6 |
winoros
reviewed
Jun 18, 2019
crazycs520
reviewed
Jun 18, 2019
| return sorted[i] > sorted[j] | ||
| }) | ||
| numTop = mathutil.MinUint32(uint32(len(counter)), numTop) | ||
| lastTopCnt := sorted[numTop-1] |
There was a problem hiding this comment.
if numTop is 0, this will panic? executor/analyze.go #334 set numTop is 0
There was a problem hiding this comment.
No, they don't have top n and won't go into this function.
zz-jason
added
the
priority/release-blocker
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-unit-test |
2 similar comments
|
/run-unit-test |
|
/run-unit-test |
zz-jason
added
status/LGT2
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Jun 22, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The index CM sketch of fast analyze is wrong, it does not consider the prefix columns.
What is changed and how it works?
Built cm sketch for each prefix columns of index, and merge them into one as the final result.
Check List
Tests
Code changes
Side effects
Related changes