*: Fix #254 #334
Merged
*: Fix #254 #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -489,9 +490,9 @@ func (d *ddl) addColumn(schema model.CIStr, tbl table.Table, spec *AlterSpecific | |||
| tb := tbl.(*tables.Table) | |||
| tb.Columns = newCols | |||
| // TODO: update index | |||
| // TODO: update default value | |||
| // update infomation schema | |||
| updateDefaultValue(ctx, tb, col) | |||
| _, err = tb.AddRecord(ctx, []interface{}{1}) | ||
| _, err = tb.AddRecord(ctx, []interface{}{2}) | ||
| c.Assert(err, IsNil) | ||
| alterStmt := statement(`alter table t2 add b enum("bbb") first`).(*stmts.AlterTableStmt) |
There was a problem hiding this comment.
Should add a test that after u add a new column, u can select the updated value.
There was a problem hiding this comment.
tb.Row() will get the updated values.
There was a problem hiding this comment.
Yes, but need a value equal check.
| return errors.Trace(err0) | ||
| } | ||
| k := t.RecordKey(handle, col) | ||
| colID, err0 := tables.ColumnID(k) |
There was a problem hiding this comment.
Seems that in addColumn there will be no new column, so here colID == col.ID will always be true?
There was a problem hiding this comment.
yep.
here colID == col.ID is always true. Because the key is produced by RecordKey(handle, col)。
|
LGTM |
shenli
added a commit
that referenced
this pull request
Oct 10, 2015
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* optimize parse csv and local backend write tikv * fix * remove IndexAnyUtf8 because the implement buggy for csv parser * update pebble and options
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Shuaipeng Yu <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
Signed-off-by: Shuaipeng Yu <[email protected]>
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Signed-off-by: Shuaipeng Yu <[email protected]>
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
May 11, 2023
Signed-off-by: Wish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #254