Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window function: function name of error message should be lowercase(#11047) #11118

Conversation

SunRunAway
Copy link
Contributor

Cherry pick of #11047 on release-3.0.

#11047: window function: function name of error message should be

@SunRunAway
Copy link
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@SunRunAway SunRunAway changed the title Automated cherry pick of #11047: window function: function name of error message should be window function: function name of error message should be lowercase Jul 8, 2019
@SunRunAway
Copy link
Contributor Author

/run-common-test tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@SunRunAway SunRunAway force-pushed the automated-cherry-pick-of-#11047-release-3.0 branch from 9625532 to 6beb943 Compare July 8, 2019 03:30
@SunRunAway SunRunAway force-pushed the automated-cherry-pick-of-#11047-release-3.0 branch from 6beb943 to b43af42 Compare July 8, 2019 03:32
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor Author

Should be merged after #11120 to fix DATA RACE.

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. type/3.0 cherry-pick labels Jul 8, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jul 8, 2019

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2019
@zz-jason zz-jason merged commit c352e0d into pingcap:release-3.0 Jul 8, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#11047-release-3.0 branch July 8, 2019 05:16
@XuHuaiyu XuHuaiyu changed the title window function: function name of error message should be lowercase window function: function name of error message should be lowercase(#11047) Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants