Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the modify column operation on the bit column #12008

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 3, 2019

What problem does this PR solve?

Before this PR:

create table t (i int, b bit);
alter table t modify b bit;
ERROR 1105 (HY000): unsupported modify column unsigned false not match origin true

Fix #11800

What is changed and how it works?

Add the UnsignedFlag to bit like add column when doing modify column.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the modify column operation on the bit column.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #12008 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12008   +/-   ##
===========================================
  Coverage   81.4793%   81.4793%           
===========================================
  Files           447        447           
  Lines         95747      95747           
===========================================
  Hits          78014      78014           
  Misses        12172      12172           
  Partials       5561       5561

@coocood
Copy link
Member

coocood commented Sep 4, 2019

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. labels Sep 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

@zimulala merge failed.

@winkyao
Copy link
Contributor

winkyao commented Sep 5, 2019

/run-integration-common-test

@winkyao
Copy link
Contributor

winkyao commented Sep 5, 2019

/run-common-test

@winkyao
Copy link
Contributor

winkyao commented Sep 5, 2019

/run-integration-common-test

@winkyao
Copy link
Contributor

winkyao commented Sep 5, 2019

/run-common-test

@winkyao
Copy link
Contributor

winkyao commented Sep 5, 2019

/run-integration-common-test -tidb-test=pr/880

@AilinKid
Copy link
Contributor

AilinKid commented Sep 5, 2019

/run-all-tests

@zimulala
Copy link
Contributor Author

zimulala commented Sep 5, 2019

/run-common-test
/run-integration-common-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

cherry pick to release-3.0 in PR #12052

@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

cherry pick to release-2.1 failed

@tohghua
Copy link

tohghua commented Sep 18, 2019

cherry pick to release-2.1 failed

What does this mean? Will the fix be merged to 2.1?

@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @zimulala PTAL.

@zimulala
Copy link
Contributor Author

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2020

cherry pick to release-2.1 in PR #16312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alter table failed with bit column
9 participants