Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the modify column operation on the bit column (#12008) #12052

Merged
merged 3 commits into from
Sep 10, 2019
Merged

ddl: fix the modify column operation on the bit column (#12008) #12052

merged 3 commits into from
Sep 10, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 5, 2019

cherry-pick #12008 to release-3.0

What problem does this PR solve?

Before this PR：

create table t (i int, b bit);
alter table t modify b bit;
ERROR 1105 (HY000): unsupported modify column unsigned false not match origin true

Fix #11800

What is changed and how it works?

Add the UnsignedFlag to bit like add column when doing modify column.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the modify column operation on the bit column.

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 5, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 5, 2019
Merged
tangenta
tangenta reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520
crazycs520 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 9, 2019

@sre-bot merge failed.

@crazycs520
Copy link
Contributor

/run-all-tests

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

Your auto merge job has been accepted, waiting for #11953

This was referenced Sep 10, 2019
Merged
Merged
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 247f10b into pingcap:release-3.0 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @crazycs520 @zz-jason @tangenta @zimulala