executor, expression: 1. rename tryToMatch to tryToMatchOuters 2. tiny refine tryToMatchOuters #12138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-refine tryToMatchOuters
XuHuaiyu
changed the title
XuHuaiyu
requested review from
qw4990,
SunRunAway and
zz-jason
and removed request for
qw4990
|
/run-all-tests |
zz-jason
reviewed
Sep 10, 2019
expression/chunk_executor.go
Outdated
| filterResult int64 | ||
| bVal, isNullResult bool | ||
| err error | ||
| ) |
There was a problem hiding this comment.
how about moving these variable definition out of the for loop?
qw4990
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for #12144 |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12138 +/- ##
===========================================
Coverage 81.3005% 81.3005%
===========================================
Files 452 452
Lines 96741 96741
===========================================
Hits 78651 78651
Misses 12450 12450
Partials 5640 5640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
N/A
Code changes
Side effects
N/A
Related changes
N/A
Release note
N/A