Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx/variable: refine slow log output by not print useless info (#12016) #12144

Merged
merged 4 commits into from
Sep 11, 2019
Merged

sessionctx/variable: refine slow log output by not print useless info (#12016) #12144

merged 4 commits into from
Sep 11, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 11, 2019

cherry-pick #12016 to release-3.0

What problem does this PR solve?

What is changed and how it works

No need to print cop info when there is no cop task.

eg:

# Time: 2019-09-03T22:29:15.928961+08:00
# Txn_start_ts: 0
# User: root@::1
# Conn_ID: 1
# Query_time: 4.55850739
# DB: test
# Is_internal: false
# Digest: ff607ecdf92ded60eae3d47bd165392258321403520610cf5354fd5cf7057c53
# Num_cop_tasks: 0
# Cop_proc_avg: 0 Cop_proc_p90: 0 Cop_proc_max: 0 Cop_proc_addr:
# Cop_wait_avg: 0 Cop_wait_p90: 0 Cop_wait_max: 0 Cop_wait_addr:
# Succ: true
split table t between (0) and (10000) regions 5;

As you can see, Num_cop_tasks is 0, then the cop log is redundant.

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 11, 2019
Merged
@sre-bot sre-bot added type/usability type/3.0 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Sep 11, 2019
zz-jason
zz-jason reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2019
@sre-bot sre-bot mentioned this pull request Sep 11, 2019
Merged
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3261e37 into pingcap:release-3.0 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@lonng lonng Awaiting requested review from lonng

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @jackysp @zz-jason @crazycs520