privilege: using system session to execute internal sql of RBAC #13820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13820 +/- ##
================================================
- Coverage 80.2264% 80.1356% -0.0908%
================================================
Files 474 474
Lines 117647 117200 -447
================================================
- Hits 94384 93919 -465
- Misses 15839 15851 +12
- Partials 7424 7430 +6 |
|
/run-all-tests |
|
LGTM |
imtbkcat
force-pushed
the
rbacInternal
branch
from
4a20944
to
2f3080a
Compare
|
/run-all-tests |
jackysp
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13852 |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Dec 4, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 5, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some RBAC's internal sql were executed by
SQLExecutor.Execute, which will be recored by binlog. Interal sql should not recored by binlog.What is changed and how it works?
Use system session to execute all interal sql of RBAC.
Check List
Tests
Code changes
Side effects
Related changes