Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: using system session to execute internal sql of RBAC (#13820) #13890

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Dec 4, 2019

What problem does this PR solve?

cherry-pick #13820 with conflict resolved.

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Dec 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

/run-all-tests

@imtbkcat
Copy link
Author

imtbkcat commented Dec 5, 2019

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Dec 5, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

Your auto merge job has been accepted, waiting for 13892

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

@imtbkcat merge failed.

@zyxbest
Copy link
Contributor

zyxbest commented Dec 5, 2019

/rebuild

@zyxbest
Copy link
Contributor

zyxbest commented Dec 5, 2019

/build

@jackysp
Copy link
Member

jackysp commented Dec 5, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 251574b into pingcap:release-3.0 Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege component/session status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants