executor: add log for commit work #13965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13965 +/- ##
===========================================
Coverage 80.1928% 80.1928%
===========================================
Files 480 480
Lines 120416 120416
===========================================
Hits 96565 96565
Misses 16158 16158
Partials 7693 7693 |
jackysp
changed the title
|
Does this pr need to be cherry-pick to release-3.0? @cfzjywxk |
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The original
AddRecordLdfunction used inload datastatement, will not report error to caller.Problem:
Loading 300 millon rows in tpch lineitem table into tidb, after loaded row counts over 50800000, the load data commit goroutine will always write zero rows processing one commit task, because of error "[autoid:1467]Failed to read auto-increment value from storage engine" from
AddRecord. (related to #13648, need more investigation on this), add this error not reported, so the loading process seems got stuckWhat is changed and how it works?
AddRecordLdfunction ifAddRecordfailedCheck List
Tests
tpch.lineitemdata with 300million rowsCode changes
Side effects
Related changes
Release note