Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: report error in AddRecordLD function #13980

Merged
merged 3 commits into from
Dec 10, 2019
Merged

executor: report error in AddRecordLD function #13980

merged 3 commits into from
Dec 10, 2019

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Dec 9, 2019

What problem does this PR solve?

Cherry-pick #13965

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • Write release note for bug-fix or new feature.

@cfzjywxk cfzjywxk added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Dec 9, 2019
@jackysp jackysp changed the title [executor] Report error in AddRecordLD function executor: report error in AddRecordLD function Dec 9, 2019
@jackysp
Copy link
Member

jackysp commented Dec 9, 2019

Do we need the logs in #13965 ?

@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Dec 9, 2019

Do we need the logs in #13965 ?

Time usage log added

jackysp
jackysp reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2019
@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Dec 9, 2019

@imtbkcat PTAL

bb7133
bb7133 approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit e329379 into pingcap:release-3.0 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@bb7133 bb7133 bb7133 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfzjywxk @jackysp @sre-bot @bb7133